Skip to content

REF: implement test_astype #33734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

Split/parametrized in some places.

Comment on lines +552 to +562
with option_context("display.max_columns", 20):
result = str(timezone_frame)
assert (
"0 2013-01-01 2013-01-01 00:00:00-05:00 2013-01-01 00:00:00+01:00"
) in result
assert (
"1 2013-01-02 NaT NaT"
) in result
assert (
"2 2013-01-03 2013-01-03 00:00:00-05:00 2013-01-03 00:00:00+01:00"
) in result
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks out of place

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbrockmendel lgtm.

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Apr 23, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Apr 23, 2020
@jreback jreback merged commit 17dc6b0 into pandas-dev:master Apr 25, 2020
@jreback
Copy link
Contributor

jreback commented Apr 25, 2020

thanks

@jbrockmendel jbrockmendel deleted the ref-tst-astype branch April 25, 2020 21:02
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants