REF: implement _validate_comparison_value #33716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Apr 23, 2020
| @@ -60,29 +60,24 @@ def _datetimelike_array_cmp(cls, op): | |||
| opname = f"__{op.__name__}__" | |||
| nat_result = opname == "__ne__" | |||
|
|
|||
| @unpack_zerodim_and_defer(opname) | |||
| def wrapper(self, other): | |||
| class InvalidComparison(Exception): | |||
There was a problem hiding this comment.
is this meant to be internal or external?
There was a problem hiding this comment.
kk i would document that as such (followon ok)
jreback
approved these changes
Apr 23, 2020
| @@ -60,29 +60,24 @@ def _datetimelike_array_cmp(cls, op): | |||
| opname = f"__{op.__name__}__" | |||
| nat_result = opname == "__ne__" | |||
|
|
|||
| @unpack_zerodim_and_defer(opname) | |||
| def wrapper(self, other): | |||
| class InvalidComparison(Exception): | |||
There was a problem hiding this comment.
kk i would document that as such (followon ok)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to match the patterns we use for all the other DTA/TDA/PA methods that have an
other-like arg.No logic should be changed here, just moved around.