Skip to content

TYP: remove #type:ignore from core.arrays.datetimelike #33705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Apr 21, 2020

pandas\core\arrays\datetimelike.py:1535: error: Signatures of "iadd" and "add" are incompatible
pandas\core\arrays\datetimelike.py:1544: error: Signatures of "isub" and "sub" are incompatible

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Apr 21, 2020
@jbrockmendel
Copy link
Member

Nice, LGTM pending green

@WillAyd WillAyd added this to the 1.1 milestone Apr 22, 2020
@WillAyd WillAyd merged commit cf61be6 into pandas-dev:master Apr 22, 2020
@WillAyd
Copy link
Member

WillAyd commented Apr 22, 2020

Thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the unpack_zerodim_and_defer branch April 22, 2020 11:27
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants