Skip to content

fix bug of overflow validaion in 'reshape' #33697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chjinche
Copy link

@chjinche chjinche commented Apr 21, 2020

@pep8speaks
Copy link

Hello @chjinche! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 119:89: E501 line too long (93 > 88 characters)

@simonjayhawkins
Copy link
Member

Thanks @chjinche for the PR

can you add a release note and a test (for the test I think can use #26314 (comment))

@simonjayhawkins simonjayhawkins added Bug Numeric Operations Arithmetic, Comparison, and Logical operations Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Apr 21, 2020
@simonjayhawkins
Copy link
Member

@chjinche closing as stale. ping to reopen if you want to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Numeric Operations Arithmetic, Comparison, and Logical operations Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pivot / unstack on large data frame does not work int32 overflow
3 participants