BUG: arg validation in DTA/TDA/PA.take, DTI/TDI/PI.where #33685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks fine, pls rebase |
|
rebased+green |
| @@ -508,6 +508,12 @@ def test_take_fill_valid(self, datetime_index, tz_naive_fixture): | |||
| # require NaT, not iNaT, as it could be confused with an integer | |||
| arr.take([-1, 1], allow_fill=True, fill_value=value) | |||
|
|
|||
| value = np.timedelta64("NaT", "ns") | |||
| msg = f"'fill_value' should be a {self.dtype}. Got '{str(value)}'." | |||
There was a problem hiding this comment.
I think normally shouldn't need str in f-string. could this be a numpy bug?
There was a problem hiding this comment.
i forget exactly which case broke without the extra str, but plausibly numpy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of really similar validation/casting methods in these classes. This is a step in smoothing out the differences between them so we can share them.