CLN,TYP: Use subsitutions in info docstrings #33673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
approved these changes
Apr 20, 2020
| DataFrame.describe: Generate descriptive statistics of DataFrame | ||
| columns. | ||
| DataFrame.memory_usage: Memory usage of DataFrame columns.""", | ||
| ) |
There was a problem hiding this comment.
or keep the text adjacent to the implementation
There was a problem hiding this comment.
@jbrockmendel that's a good suggestion - have indented
…ngs' into use-subsitutions-in-info-docstrings
|
Lgtm - @jbrockmendel merge if happy |
|
Thanks @MarcoGorelli |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
* add subs in info.py * substitute docstring in frame.py * Add type annotations * reinstate data parameter * revert removed line * indent docstring * fix validation of docstrings * fix indentation of max_columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another precursor to #31796, which should make it easier to review/merge
screenshots of docs