Skip to content

CLN: make Categorical.codes a simpler property #33667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@topper-123 topper-123 added Categorical Categorical Data Type Clean labels Apr 20, 2020
@topper-123 topper-123 added this to the 1.1 milestone Apr 20, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't imagine anyone relying on the exception type being raised for this scenario, so I guess that a whatsnew is not required.

@jorisvandenbossche jorisvandenbossche merged commit 38e1b9b into pandas-dev:master Apr 20, 2020
@jorisvandenbossche
Copy link
Member

Thanks!

@jbrockmendel jbrockmendel deleted the cat-codes branch April 20, 2020 15:29
CloseChoice pushed a commit to CloseChoice/pandas that referenced this pull request Apr 20, 2020
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Clean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants