TST: CI checks against direct imports from conftest.py #33664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SaturnFromTitan
commented
Apr 20, 2020
SaturnFromTitan
commented
- closes Make a code check which bans imports of fixtures in tests #30914
SaturnFromTitan
commented
Apr 20, 2020
| @@ -150,7 +150,13 @@ if [[ -z "$CHECK" || "$CHECK" == "patterns" ]]; then | |||
| # Check for imports from pandas._testing instead of `import pandas._testing as tm` | |||
| invgrep -R --include="*.py*" -E "from pandas._testing import" pandas/tests | |||
| RET=$(($RET + $?)) ; echo $MSG "DONE" | |||
| invgrep -R --include="*.py*" -E "from pandas.util import testing as tm" pandas/tests | |||
| invgrep -R --include="*.py*" -E "from pandas import _testing as tm" pandas/tests | |||
There was a problem hiding this comment.
I just converted this from util.testing to ._testing. Seems like this code check wasn't adapted to the new location of the testing module.
It's not related, but as the PR is tiny otherwise, I think it's ok to include it.
SaturnFromTitan
commented
Apr 20, 2020
| RET=$(($RET + $?)) ; echo $MSG "DONE" | ||
|
|
||
| # No direct imports from conftest | ||
| invgrep -R --include="*.py*" -E "conftest import" pandas/tests |
There was a problem hiding this comment.
using "conftest import" instead of "pandas.conftest import" to make it work for all conftest files
SaturnFromTitan
changed the title
SaturnFromTitan
added
the
Testing
SaturnFromTitan
changed the title
simonjayhawkins
approved these changes
Apr 20, 2020
|
thanks @SaturnFromTitan |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.