TST: Dtype constants into pandas._testing to avoid direct imports from conftest #33661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaturnFromTitan
added
the
Testing
SaturnFromTitan
force-pushed
the
dtype-constants-into-testing
branch
from
4ca61b8 to
138c1e3
Compare
SaturnFromTitan
force-pushed
the
dtype-constants-into-testing
branch
from
138c1e3 to
1bd49e5
Compare
SaturnFromTitan
changed the title
|
looks pretty good |
|
LGTM pending green |
|
@jbrockmendel @jreback Thanks for the review. CI is green now. |
|
thanks @SaturnFromTitan |
CloseChoice
pushed a commit
to CloseChoice/pandas
that referenced
this pull request
Apr 20, 2020
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #30914
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffTook a naive approach to move these constants into
pandas._testing. Could also move them to a separate module instead. Let me know what you think is best.