-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: _AXIS_TO_AXIS_NUMBER to simplify axis access #33637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f0b9eb8
REF: _get_axis, _get_axis_name, _get_axis_number
topper-123 28e050e
clean _AXIS_NAMES
topper-123 7932822
Simpler warning
topper-123 c6bc5eb
fix cookbook.rst
topper-123 6ffa2f5
DOC: remove alias section from cookbook.rst
topper-123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8787,8 +8787,11 @@ def isin(self, values) -> "DataFrame": | |
# ---------------------------------------------------------------------- | ||
# Add index and columns | ||
_AXIS_ORDERS = ["index", "columns"] | ||
_AXIS_NUMBERS = {"index": 0, "columns": 1} | ||
_AXIS_NAMES = {0: "index", 1: "columns"} | ||
_AXIS_TO_AXIS_NUMBER: Dict[Axis, int] = { | ||
**NDFrame._AXIS_TO_AXIS_NUMBER, | ||
1: 1, | ||
"columns": 1, | ||
} | ||
_AXIS_REVERSED = True | ||
_AXIS_LEN = len(_AXIS_ORDERS) | ||
_info_axis_number = 1 | ||
|
@@ -8801,6 +8804,18 @@ def isin(self, values) -> "DataFrame": | |
axis=0, doc="The column labels of the DataFrame." | ||
) | ||
|
||
@property | ||
def _AXIS_NUMBERS(self) -> Dict[str, int]: | ||
""".. deprecated:: 1.1.0""" | ||
super()._AXIS_NUMBERS | ||
return {"index": 0, "columns": 1} | ||
|
||
@property | ||
def _AXIS_NAMES(self) -> Dict[int, str]: | ||
""".. deprecated:: 1.1.0""" | ||
super()._AXIS_NAMES | ||
return {0: "index", 1: "columns"} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Neither |
||
# ---------------------------------------------------------------------- | ||
# Add plotting methods to DataFrame | ||
plot = CachedAccessor("plot", pandas.plotting.PlotAccessor) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should just remove this section entirely. it isn't really tested / nor well supported.