Skip to content

CLN: Clean missing.py #33631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2020
Merged

CLN: Clean missing.py #33631

merged 1 commit into from
Apr 19, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Apr 18, 2020

Random nitpick here

@dsaxton dsaxton added the Clean label Apr 18, 2020
@WillAyd
Copy link
Member

WillAyd commented Apr 18, 2020

@jbrockmendel

values = getattr(obj, "_values", obj)
dtype = values.dtype

if is_extension:
if is_extension_array_dtype(dtype):
result = values.isna()
elif is_string_dtype(dtype):
result = _isna_string_dtype(values, dtype, old=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback added this to the 1.1 milestone Apr 19, 2020
@jreback jreback merged commit ad8ce0b into pandas-dev:master Apr 19, 2020
@jreback
Copy link
Contributor

jreback commented Apr 19, 2020

thanks @dsaxton

@dsaxton dsaxton deleted the clean-missing branch April 19, 2020 22:25
CloseChoice pushed a commit to CloseChoice/pandas that referenced this pull request Apr 20, 2020
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants