Skip to content

inspect-safety for DataFrame._constructor_expanddim #33628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2020
Merged

inspect-safety for DataFrame._constructor_expanddim #33628

merged 4 commits into from
Apr 21, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 18, 2020 •
edited by TomAugspurger
Loading

TomAugspurger
TomAugspurger reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once you get the jinja2 thing sorted out.

@TomAugspurger
Copy link
Contributor

Ah, interesting, it's failing without jinja2, since df.style returns a Styler, which requires jinja2 to initialize.

I'm fine with just ignoring this for now, and essentially requiring jinaj2 for inspect.getmembers to work.

@jbrockmendel
Copy link
Member Author

I'm fine with just ignoring this for now, and essentially requiring jinaj2 for inspect.getmembers to work.

agreed

@jreback jreback mentioned this pull request Apr 21, 2020
Closed
5 tasks
@jreback jreback added this to the 1.1 milestone Apr 21, 2020
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Apr 21, 2020
@jreback jreback merged commit f16179a into pandas-dev:master Apr 21, 2020
@jreback
Copy link
Contributor

jreback commented Apr 21, 2020

thanks

@simonjayhawkins
Copy link
Member

how about a follow-up for Series._constructor_sliced

@jbrockmendel jbrockmendel deleted the nih branch April 21, 2020 14:37
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
@jbrockmendel @rhshadrach
inspect-safety for DataFrame._constructor_expanddim (pandas-dev#33628)
35b8b8c
@TomAugspurger TomAugspurger mentioned this pull request Jul 6, 2020
Closed
@jorisvandenbossche jorisvandenbossche mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Not supported for DataFrames Exception triggered by a simple inspect.getmembers() call on a DataFrame
4 participants
@jbrockmendel @TomAugspurger @jreback @simonjayhawkins