-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: pd.Series.replace does not preserve the original dtype #33622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
kotamatsuoka
wants to merge
9
commits into
pandas-dev:master
from
kotamatsuoka:original-dtype-with-replace
Closed
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9ef9f9e
BUG: pd.Series.replace does not preserve the original dtype
kotamatsuoka 8be0127
Changes according to comments
kotamatsuoka 078aca1
Remove hard-code
kotamatsuoka 571ab8a
Update infer_dtype_from
kotamatsuoka 6ae7a09
Merge branch 'master' into original-dtype-with-replace
kotamatsuoka b227024
Move conditional branch out of infer_dtype_from()
kotamatsuoka a62c896
Remove specifically handling
kotamatsuoka 1a9fa40
add test cases
kotamatsuoka b777345
move is_categorical_dtype()
kotamatsuoka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -250,7 +250,7 @@ def test_replace2(self): | |
def test_replace_with_dictlike_and_string_dtype(self): | ||
# GH 32621 | ||
s = pd.Series(["one", "two", np.nan], dtype="string") | ||
expected = pd.Series(["1", "2", np.nan]) | ||
expected = pd.Series(["1", "2", np.nan], dtype="string") | ||
result = s.replace({"one": "1", "two": "2"}) | ||
tm.assert_series_equal(expected, result) | ||
|
||
|
@@ -402,3 +402,20 @@ def test_replace_only_one_dictlike_arg(self): | |
msg = "Series.replace cannot use dict-value and non-None to_replace" | ||
with pytest.raises(ValueError, match=msg): | ||
ser.replace(to_replace, value) | ||
|
||
@pytest.mark.parametrize( | ||
"series, to_replace, expected", | ||
[ | ||
( | ||
pd.Series(["one", "two"], dtype="string"), | ||
{"one": "1", "two": "2"}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add a bunch more tests which can hit the other EA types, e.g. Intervval, Period, Datetime w/tz There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added test cases. |
||
"string", | ||
), | ||
(pd.Series([1, 2], dtype="int64"), {1: 10, 2: 20}, "int64"), | ||
(pd.Series([True, False], dtype="bool"), {True: False}, "bool"), | ||
], | ||
) | ||
def test_replace_dtype(self, series, to_replace, expected): | ||
kotamatsuoka marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# GH 33484 | ||
result = str(series.replace(to_replace).dtype) | ||
assert expected == result |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just use is_extension_array_dtype here