REF: Make numba function cache globally accessible #33621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/groupby/generic.py
Outdated
| @@ -76,6 +76,7 @@ | |||
| from pandas.core.internals import BlockManager, make_block | |||
| from pandas.core.series import Series | |||
| from pandas.core.util.numba_ import ( | |||
| _numba_func_cache, | |||
There was a problem hiding this comment.
If it’s cross-module, can it be non-private?
|
Does this cache ever get invalidated? |
No. Nothing immediately comes to mind why we need to invalidate it at a certain point. Open to thoughts. |
|
thanks. |
CloseChoice
pushed a commit
to CloseChoice/pandas
that referenced
this pull request
Apr 20, 2020
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffFor all the numba accessible operations, we use a cache to store compiled JIT'd functions for performance.
This
_numba_func_cacheused to be an attribute ofRollingandGroupbyobjects before, but while working on #33388, I cannot easily rely on having access to those objects.This PR moves
_numba_func_cachetopandas/core/util/numba_.py. Since this cache is now globally shared, the key has changed from_numba_func_cache[func] = compiled_functo_numba_func_cache[(func, op)] = compiled_func