Skip to content

DOC/CLN: Clean/Fix documentation for Window module #33608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/code_checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,8 @@ fi
### DOCSTRINGS ###
if [[ -z "$CHECK" || "$CHECK" == "docstrings" ]]; then

MSG='Validate docstrings (GL03, GL04, GL05, GL06, GL07, GL09, GL10, SS04, SS05, PR03, PR04, PR05, PR10, EX04, RT01, RT04, RT05, SA02, SA03, SA05)' ; echo $MSG
$BASE_DIR/scripts/validate_docstrings.py --format=actions --errors=GL03,GL04,GL05,GL06,GL07,GL09,GL10,SS04,SS05,PR03,PR04,PR05,PR10,EX04,RT01,RT04,RT05,SA02,SA03,SA05
MSG='Validate docstrings (GL03, GL04, GL05, GL06, GL07, GL09, GL10, SS04, SS05, PR03, PR04, PR05, PR10, EX04, RT01, RT04, RT05, SA02, SA03)' ; echo $MSG
$BASE_DIR/scripts/validate_docstrings.py --format=actions --errors=GL03,GL04,GL05,GL06,GL07,GL09,GL10,SS04,SS05,PR03,PR04,PR05,PR10,EX04,RT01,RT04,RT05,SA02,SA03
RET=$(($RET + $?)) ; echo $MSG "DONE"

MSG='Validate correct capitalization among titles in documentation' ; echo $MSG
Expand Down
6 changes: 4 additions & 2 deletions pandas/core/window/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@

See Also
--------
Series.%(name)s : Series %(name)s.
DataFrame.%(name)s : DataFrame %(name)s.
pandas.Series.%(name)s : Calling object with Series data.
pandas.DataFrame.%(name)s : Calling object with DataFrame data.
pandas.Series.%(func_name)s : Similar method for Series.
pandas.DataFrame.%(func_name)s : Similar method for DataFrame.
"""


Expand Down
10 changes: 5 additions & 5 deletions pandas/core/window/ewm.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ def func(arg):

return self._wrap_results(results, block_list, obj, exclude)

@Substitution(name="ewm")
@Substitution(name="ewm", func_name="mean")
@Appender(_doc_template)
def mean(self, *args, **kwargs):
"""
Expand All @@ -279,7 +279,7 @@ def mean(self, *args, **kwargs):
nv.validate_window_func("mean", args, kwargs)
return self._apply("ewma", **kwargs)

@Substitution(name="ewm")
@Substitution(name="ewm", func_name="std")
@Appender(_doc_template)
@Appender(_bias_template)
def std(self, bias=False, *args, **kwargs):
Expand All @@ -291,7 +291,7 @@ def std(self, bias=False, *args, **kwargs):

vol = std

@Substitution(name="ewm")
@Substitution(name="ewm", func_name="var")
@Appender(_doc_template)
@Appender(_bias_template)
def var(self, bias=False, *args, **kwargs):
Expand All @@ -313,7 +313,7 @@ def f(arg):

return self._apply(f, **kwargs)

@Substitution(name="ewm")
@Substitution(name="ewm", func_name="cov")
@Appender(_doc_template)
def cov(self, other=None, pairwise=None, bias=False, **kwargs):
"""
Expand Down Expand Up @@ -360,7 +360,7 @@ def _get_cov(X, Y):
self._selected_obj, other._selected_obj, _get_cov, pairwise=bool(pairwise)
)

@Substitution(name="ewm")
@Substitution(name="ewm", func_name="corr")
@Appender(_doc_template)
def corr(self, other=None, pairwise=None, **kwargs):
"""
Expand Down
11 changes: 5 additions & 6 deletions pandas/core/window/expanding.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,8 @@ def _get_window(self, other=None, **kwargs):
"""
See Also
--------
DataFrame.expanding.aggregate
DataFrame.rolling.aggregate
DataFrame.aggregate
pandas.DataFrame.aggregate : Similar DataFrame method.
pandas.Series.aggregate : Similar Series method.
"""
)

Expand Down Expand Up @@ -172,7 +171,7 @@ def sum(self, *args, **kwargs):
nv.validate_expanding_func("sum", args, kwargs)
return super().sum(*args, **kwargs)

@Substitution(name="expanding")
@Substitution(name="expanding", func_name="max")
@Appender(_doc_template)
@Appender(_shared_docs["max"])
def max(self, *args, **kwargs):
Expand Down Expand Up @@ -208,7 +207,7 @@ def var(self, ddof=1, *args, **kwargs):
nv.validate_expanding_func("var", args, kwargs)
return super().var(ddof=ddof, **kwargs)

@Substitution(name="expanding")
@Substitution(name="expanding", func_name="skew")
@Appender(_doc_template)
@Appender(_shared_docs["skew"])
def skew(self, **kwargs):
Expand Down Expand Up @@ -252,7 +251,7 @@ def quantile(self, quantile, interpolation="linear", **kwargs):
quantile=quantile, interpolation=interpolation, **kwargs
)

@Substitution(name="expanding")
@Substitution(name="expanding", func_name="cov")
@Appender(_doc_template)
@Appender(_shared_docs["cov"])
def cov(self, other=None, pairwise=None, ddof=1, **kwargs):
Expand Down
92 changes: 47 additions & 45 deletions pandas/core/window/rolling.py
Original file line number Diff line number Diff line change
Expand Up @@ -540,8 +540,8 @@ def aggregate(self, func, *args, **kwargs):

See Also
--------
Series.sum : Reducing sum for Series.
DataFrame.sum : Reducing sum for DataFrame.
pandas.Series.sum : Reducing sum for Series.
pandas.DataFrame.sum : Reducing sum for DataFrame.

Examples
--------
Expand Down Expand Up @@ -618,10 +618,10 @@ def aggregate(self, func, *args, **kwargs):

See Also
--------
Series.%(name)s : Calling object with Series data.
DataFrame.%(name)s : Calling object with DataFrames.
Series.mean : Equivalent method for Series.
DataFrame.mean : Equivalent method for DataFrame.
pandas.Series.%(name)s : Calling object with Series data.
pandas.DataFrame.%(name)s : Calling object with DataFrames.
pandas.Series.mean : Equivalent method for Series.
pandas.DataFrame.mean : Equivalent method for DataFrame.

Examples
--------
Expand Down Expand Up @@ -667,10 +667,10 @@ def aggregate(self, func, *args, **kwargs):

See Also
--------
Series.%(name)s : Calling object with Series data.
DataFrame.%(name)s : Calling object with DataFrames.
Series.var : Equivalent method for Series.
DataFrame.var : Equivalent method for DataFrame.
pandas.Series.%(name)s : Calling object with Series data.
pandas.DataFrame.%(name)s : Calling object with DataFrames.
pandas.Series.var : Equivalent method for Series.
pandas.DataFrame.var : Equivalent method for DataFrame.
numpy.var : Equivalent method for Numpy array.

Notes
Expand Down Expand Up @@ -727,10 +727,10 @@ def aggregate(self, func, *args, **kwargs):

See Also
--------
Series.%(name)s : Calling object with Series data.
DataFrame.%(name)s : Calling object with DataFrames.
Series.std : Equivalent method for Series.
DataFrame.std : Equivalent method for DataFrame.
pandas.Series.%(name)s : Calling object with Series data.
pandas.DataFrame.%(name)s : Calling object with DataFrames.
pandas.Series.std : Equivalent method for Series.
pandas.DataFrame.std : Equivalent method for DataFrame.
numpy.std : Equivalent method for Numpy array.

Notes
Expand Down Expand Up @@ -1030,8 +1030,8 @@ def _get_window(
"""
See Also
--------
pandas.DataFrame.rolling.aggregate
pandas.DataFrame.aggregate
pandas.DataFrame.aggregate : Similar DataFrame method.
pandas.Series.aggregate : Similar Series method.
"""
)

Expand Down Expand Up @@ -1146,9 +1146,9 @@ class _Rolling_and_Expanding(_Rolling):

See Also
--------
Series.%(name)s : Calling object with Series data.
DataFrame.%(name)s : Calling object with DataFrames.
DataFrame.count : Count of the full DataFrame.
pandas.Series.%(name)s : Calling object with Series data.
pandas.DataFrame.%(name)s : Calling object with DataFrames.
pandas.DataFrame.count : Count of the full DataFrame.

Examples
--------
Expand Down Expand Up @@ -1243,8 +1243,10 @@ def count(self):

See Also
--------
Series.%(name)s : Series %(name)s.
DataFrame.%(name)s : DataFrame %(name)s.
pandas.Series.%(name)s : Calling object with Series data.
pandas.DataFrame.%(name)s : Calling object with DataFrame data.
pandas.Series.apply : Similar method for Series.
pandas.DataFrame.apply : Similar method for DataFrame.

Notes
-----
Expand Down Expand Up @@ -1363,10 +1365,10 @@ def max(self, *args, **kwargs):

See Also
--------
Series.%(name)s : Calling object with a Series.
DataFrame.%(name)s : Calling object with a DataFrame.
Series.min : Similar method for Series.
DataFrame.min : Similar method for DataFrame.
pandas.Series.%(name)s : Calling object with a Series.
pandas.DataFrame.%(name)s : Calling object with a DataFrame.
pandas.Series.min : Similar method for Series.
pandas.DataFrame.min : Similar method for DataFrame.

Examples
--------
Expand Down Expand Up @@ -1410,10 +1412,10 @@ def mean(self, *args, **kwargs):

See Also
--------
Series.%(name)s : Calling object with Series data.
DataFrame.%(name)s : Calling object with DataFrames.
Series.median : Equivalent method for Series.
DataFrame.median : Equivalent method for DataFrame.
pandas.Series.%(name)s : Calling object with Series data.
pandas.DataFrame.%(name)s : Calling object with DataFrames.
pandas.Series.median : Equivalent method for Series.
pandas.DataFrame.median : Equivalent method for DataFrame.

Examples
--------
Expand Down Expand Up @@ -1508,10 +1510,10 @@ def skew(self, **kwargs):

See Also
--------
Series.%(name)s : Calling object with Series data.
DataFrame.%(name)s : Calling object with DataFrames.
Series.kurt : Equivalent method for Series.
DataFrame.kurt : Equivalent method for DataFrame.
pandas.Series.%(name)s : Calling object with Series data.
pandas.DataFrame.%(name)s : Calling object with DataFrames.
pandas.Series.kurt : Equivalent method for Series.
pandas.DataFrame.kurt : Equivalent method for DataFrame.
scipy.stats.skew : Third moment of a probability density.
scipy.stats.kurtosis : Reference SciPy method.

Expand Down Expand Up @@ -1564,9 +1566,9 @@ def kurt(self, **kwargs):

See Also
--------
Series.quantile : Computes value at the given quantile over all data
pandas.Series.quantile : Computes value at the given quantile over all data
in Series.
DataFrame.quantile : Computes values at the given quantile over
pandas.DataFrame.quantile : Computes values at the given quantile over
requested axis in DataFrame.

Examples
Expand Down Expand Up @@ -1690,11 +1692,11 @@ def _get_cov(X, Y):

See Also
--------
Series.%(name)s : Calling object with Series data.
DataFrame.%(name)s : Calling object with DataFrames.
Series.corr : Equivalent method for Series.
DataFrame.corr : Equivalent method for DataFrame.
%(name)s.cov : Similar method to calculate covariance.
pandas.Series.%(name)s : Calling object with Series data.
pandas.DataFrame.%(name)s : Calling object with DataFrames.
pandas.Series.corr : Equivalent method for Series.
pandas.DataFrame.corr : Equivalent method for DataFrame.
cov : Similar method to calculate covariance.
numpy.corrcoef : NumPy Pearson's correlation calculation.

Notes
Expand Down Expand Up @@ -1895,8 +1897,8 @@ def _validate_freq(self):
"""
See Also
--------
Series.rolling
DataFrame.rolling
pandas.Series.rolling : Calling object with Series data.
pandas.DataFrame.rolling : Calling object with DataFrame data.
"""
)

Expand Down Expand Up @@ -1997,7 +1999,7 @@ def sum(self, *args, **kwargs):
nv.validate_rolling_func("sum", args, kwargs)
return super().sum(*args, **kwargs)

@Substitution(name="rolling")
@Substitution(name="rolling", func_name="max")
@Appender(_doc_template)
@Appender(_shared_docs["max"])
def max(self, *args, **kwargs):
Expand Down Expand Up @@ -2033,7 +2035,7 @@ def var(self, ddof=1, *args, **kwargs):
nv.validate_rolling_func("var", args, kwargs)
return super().var(ddof=ddof, **kwargs)

@Substitution(name="rolling")
@Substitution(name="rolling", func_name="skew")
@Appender(_doc_template)
@Appender(_shared_docs["skew"])
def skew(self, **kwargs):
Expand Down Expand Up @@ -2077,7 +2079,7 @@ def quantile(self, quantile, interpolation="linear", **kwargs):
quantile=quantile, interpolation=interpolation, **kwargs
)

@Substitution(name="rolling")
@Substitution(name="rolling", func_name="cov")
@Appender(_doc_template)
@Appender(_shared_docs["cov"])
def cov(self, other=None, pairwise=None, ddof=1, **kwargs):
Expand Down