Update _core.py with missing parameters #33596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added missing parameters: - ax - subplots - sharex - sharey - secondary_y - sort_columns - stacked
|
Hello @loudlemon! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-05-03 03:42:43 UTC |
|
Not super well versed in this area so @datapythonista merge when happy |
pandas/plotting/_core.py
Outdated
| an ax is passed in; Be aware, that passing in both an ax and | ||
| sharex=True will alter all x axis labels for all axis in a figure. | ||
| sharey : bool, default False | ||
| In case aubplots=True, share y axis and set some y axis labels to invisible. |
There was a problem hiding this comment.
Typo, subplots.
Also, if you don't mind, can you quote in double backticks all these param=value cases. For example :
In case ``subplot=True``, share...
pandas/plotting/_core.py
Outdated
| sharex=True will alter all x axis labels for all axis in a figure. | ||
| sharey : bool, default False | ||
| In case aubplots=True, share y axis and set some y axis labels to invisible. | ||
| layout : tuple (optional) |
pandas/plotting/_core.py
Outdated
| stacked : bool, default False in line and bar plots, and True in area plot | ||
| If True, create stacked plot. | ||
| sort_columns : bool, default False | ||
| Sort columns names to determine plot ordering. |
There was a problem hiding this comment.
Not sure, but shouldn't be "column names"?
There was a problem hiding this comment.
that's right, column names, should have checked for all these inaccuracies
thanks for your time!
I'll make changes shortly
This was referenced Apr 26, 2020
- quote 'param=value` cases - fix a few typos
datapythonista
approved these changes
May 3, 2020
|
Thanks @loudlemon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added missing parameters:
ax
subplots
sharex
sharey
secondary_y
sort_columns
stacked
closes #xxxx
tests added / passed
passes
black pandaspasses
git diff upstream/master -u -- "*.py" | flake8 --diffwhatsnew entry