BUG: Debug grouped quantile with NA values #33571
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaxton
commented
Apr 15, 2020
dsaxton
commented
Apr 15, 2020
| expected = pd.DataFrame( | ||
| [1.0, 3.0], index=pd.Index([1.0, 3.0], name="key"), columns=["val"] |
There was a problem hiding this comment.
I'm pretty sure this test was wrong, the values for the non-null labels are 0 and 2, so these quantiles don't make sense
WillAyd
reviewed
Apr 16, 2020
| order = (values, labels) | ||
| # Get an index of values sorted by labels and then values, | ||
| # make sure missing labels sort to the back of the array | ||
| if labels.size: |
There was a problem hiding this comment.
Does the subsequent loop even account for missing labels in iteration? If not I wonder if cleaner to just remove rather than force sorting this way
There was a problem hiding this comment.
Hmm, I think we'd also have to remove from values so that the two have the same shape for lexsort (that might break what's below but I'm not sure honestly)
|
Closing as this is basically identical to #33644 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff