CLN: Change isocalendar to be a method #33533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Apr 13, 2020
For consistency with `Timestamp.isocalendar`, this should rather be a method. Followup of pandas-dev#33220, see the discussions following the merge
mgmarino
force-pushed
the
use-method-instead-of-attribute-for-isocalendar
branch
from
614e2ed to
b7a89d8
Compare
|
@mroeschke dev build was fixed in #33534 by pinning CPython. PR rebased, all green. |
|
Thanks @mgmarino for the timely and clean PRs! |
CloseChoice
pushed a commit
to CloseChoice/pandas
that referenced
this pull request
Apr 20, 2020
For consistency with `Timestamp.isocalendar`, this should rather be a method. Followup of pandas-dev#33220, see the discussions following the merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with
Timestamp.isocalendar,Series.dt.isocalendarandDatetimeIndex.isocalendarshould rather be methods and not attributes.Followup of #33220, see the discussions following the merge of that PR