Skip to content

DOC: Add missing descriptions in See Also section #33514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

DOC: Add missing descriptions in See Also section #33514

wants to merge 2 commits into from

Conversation

devjeetr
Copy link
Contributor

@devjeetr devjeetr commented Apr 13, 2020 •
edited by datapythonista
Loading

Fixed SR04 for pandas/core/window/rolling.py

@alimcmaster1
Copy link
Member

alimcmaster1 commented Apr 14, 2020 •
edited
Loading

Please ref the issue in the description. Also if you merge master the test failures will be resolved

alimcmaster1
alimcmaster1 requested changes Apr 14, 2020
View reviewed changes
pandas/tests/reshape/merge/test_merge.py
@@ -645,6 +645,39 @@ def _constructor(self):

assert isinstance(result, NotADataFrame)

def test_merge_right_duplicate_suffix(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these changes - believe you have a separate PR for these

@jbrockmendel
Copy link
Member

Is this PR about the tests or the docstrings?

@datapythonista are the docstring edits here desired? I dont find the extra verbosity helpful, but not a strong opinion

@datapythonista datapythonista changed the title Partial fix for Issue #28792 DOC: Add missing descriptions in See Also section Apr 16, 2020
@datapythonista
Copy link
Member

@datapythonista are the docstring edits here desired? I dont find the extra verbosity helpful, but not a strong opinion

Adding descriptions to the see also items is desired. But I agree with your point. I think adding DataFrame.aggregate: Alias of DataFrame.agg. is useful for users. The description added here is probably not very useful, and even confusing, since users will wonder which one they should use.

@devjeetr can you have another look, remove the unrelated changes as requested, and provide a more useful description.

@simonjayhawkins
Copy link
Member

@devjeetr closing as stale. ping if you want to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 requested changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devjeetr @alimcmaster1 @jbrockmendel @datapythonista @simonjayhawkins