Skip to content

Issue 31175 #33510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Issue 31175 #33510

wants to merge 3 commits into from

Conversation

echozzy629
Copy link

@echozzy629 echozzy629 commented Apr 13, 2020

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@pep8speaks
Copy link

pep8speaks commented Apr 13, 2020

Hello @echozzy629! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 441:89: E501 line too long (106 > 88 characters)
Line 442:17: E265 block comment should start with '# '
Line 442:89: E501 line too long (132 > 88 characters)
Line 443:17: E265 block comment should start with '# '
Line 444:28: E225 missing whitespace around operator
Line 446:34: E225 missing whitespace around operator
Line 447:32: E225 missing whitespace around operator
Line 449:32: E225 missing whitespace around operator
Line 450:89: E501 line too long (96 > 88 characters)

Line 1440:5: E303 too many blank lines (2)
Line 1460:1: W293 blank line contains whitespace
Line 1469:89: E501 line too long (119 > 88 characters)
Line 1475:1: W293 blank line contains whitespace
Line 1484:89: E501 line too long (97 > 88 characters)
Line 1488:89: E501 line too long (93 > 88 characters)
Line 1495:26: E225 missing whitespace around operator
Line 1496:1: W293 blank line contains whitespace
Line 1497:9: E265 block comment should start with '# '
Line 1498:13: E116 unexpected indentation (comment)
Line 1498:13: E265 block comment should start with '# '
Line 1499:17: E711 comparison to None should be 'if cond is None:'
Line 1500:23: E225 missing whitespace around operator
Line 1501:1: W293 blank line contains whitespace
Line 1502:9: E265 block comment should start with '# '
Line 1503:19: E711 comparison to None should be 'if cond is None:'
Line 1504:23: E225 missing whitespace around operator
Line 1504:38: E226 missing whitespace around arithmetic operator
Line 1506:9: E265 block comment should start with '# '
Line 1507:63: E225 missing whitespace around operator
Line 1508:23: E225 missing whitespace around operator
Line 1509:63: E225 missing whitespace around operator
Line 1511:9: E265 block comment should start with '# '
Line 1515:64: E225 missing whitespace around operator
Line 1517:9: E265 block comment should start with '# '
Line 1519:9: E115 expected an indented block (comment)
Line 1519:9: E265 block comment should start with '# '
Line 1520:9: E115 expected an indented block (comment)
Line 1520:9: E265 block comment should start with '# '
Line 1521:9: E115 expected an indented block (comment)
Line 1523:9: E115 expected an indented block (comment)
Line 1523:9: E265 block comment should start with '# '
Line 1525:89: E501 line too long (112 > 88 characters)
Line 1526:1: W293 blank line contains whitespace
Line 1527:9: E265 block comment should start with '# '
Line 1528:25: E225 missing whitespace around operator
Line 1530:16: E111 indentation is not a multiple of four
Line 1530:89: E501 line too long (119 > 88 characters)
Line 1531:1: W293 blank line contains whitespace
Line 1533:22: E225 missing whitespace around operator
Line 1537:9: E265 block comment should start with '# '
Line 1537:9: E303 too many blank lines (2)
Line 1538:16: E225 missing whitespace around operator
Line 1538:30: E225 missing whitespace around operator
Line 1540:16: E225 missing whitespace around operator
Line 1540:51: E225 missing whitespace around operator
Line 1541:89: E501 line too long (130 > 88 characters)
Line 1544:13: E265 block comment should start with '# '
Line 1546:89: E501 line too long (90 > 88 characters)
Line 1548:17: E265 block comment should start with '# '
Line 1553:21: E225 missing whitespace around operator
Line 1554:22: E225 missing whitespace around operator
Line 1557:28: E225 missing whitespace around operator
Line 1558:32: E225 missing whitespace around operator
Line 1559:32: E225 missing whitespace around operator
Line 1563:28: E225 missing whitespace around operator
Line 1567:9: E265 block comment should start with '# '
Line 1568:9: E265 block comment should start with '# '
Line 1569:24: E225 missing whitespace around operator
Line 1570:20: E225 missing whitespace around operator
Line 1571:15: E225 missing whitespace around operator
Line 1571:44: E231 missing whitespace after ','
Line 1571:60: E231 missing whitespace after ','
Line 1571:76: E231 missing whitespace after ','
Line 1572:20: E225 missing whitespace around operator
Line 1575:26: E225 missing whitespace around operator
Line 1575:89: E501 line too long (104 > 88 characters)

Comment last updated at 2020-04-13 04:01:10 UTC

@echozzy629 echozzy629 closed this Apr 13, 2020
@echozzy629 echozzy629 reopened this Apr 13, 2020
@echozzy629 echozzy629 closed this Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants