Added two tests for issue #29697 #33508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimcmaster1
added
the
Testing
alimcmaster1
requested changes
Apr 14, 2020
| @@ -645,6 +645,39 @@ def _constructor(self): | |||
|
|
|||
| assert isinstance(result, NotADataFrame) | |||
|
|
|||
| def test_merge_right_duplicate_suffix(self): | |||
There was a problem hiding this comment.
These tests are very similar could you use @pytest.mark.parameterize here?
There was a problem hiding this comment.
Added @pytest.mark.parameterize. I am not super familiar with pytest but I tried following other tests that used parameterize, but let me know about any changes I should make.
|
Think the best place in the file for this test method would be directly after |
I gave it a look and I agree. Moved it in the latest commit. |
|
LGTM please fix up the pep8 issues for CI to pass. @devjeetr |
|
force-pushed a lint fixup |
|
thanks @devjeetr |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two basic tests for
mergeas requested in #29697, one forhow="outer"and one forhow="right".I'm not sure if the way I'm creating duplicate columns for the
expecteddataframe is the recommended way but I could not find anything on this. Please let me know if there's a better way to do this.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff