Skip to content

CI: Setup 3.9 Travis Build #33505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 9, 2020
Merged

CI: Setup 3.9 Travis Build #33505

merged 16 commits into from
May 9, 2020

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Apr 12, 2020

This is using currently using Python 3.9.0a5+

Currently failing with

ImportError while loading conftest '/home/travis/build/pandas-dev/pandas/pandas/conftest.py'.
pandas/conftest.py:1123: in <module>
    ("period", [pd.Period(2013), pd.NaT, pd.Period(2018)]),
pandas/_libs/tslibs/period.pyx:2470: in pandas._libs.tslibs.period.Period.__new__
    freq = Resolution.get_freq(reso)
pandas/_libs/tslibs/resolution.pyx:240: in pandas._libs.tslibs.resolution.Resolution.get_freq
    return cls._reso_freq_map[resostr]
E   AttributeError: type object 'type' has no attribute '_reso_freq_map'
The command "ci/run_tests.sh" exited with 4.
cache.2
store build cache

@alimcmaster1 alimcmaster1 added Python 3.9 CI Continuous Integration labels Apr 12, 2020
@alimcmaster1
Copy link
Member Author

Test failures currently related to: #33507

@jbrockmendel
Copy link
Member

@alimcmaster1 did we determine this needs to wait on an upstream fix?

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us know when ready

ci/build39.sh Outdated
python -c "import hypothesis"

# TODO: Is there anything else in setup_env that we really want to do?
# ci/setup_env.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a line at the end

minor comments
@alimcmaster1
Copy link
Member Author

alimcmaster1 commented Apr 23, 2020

@alimcmaster1 did we determine this needs to wait on an upstream fix?

Yes waiting on a fix to the current cython alpha - cython/cython#3544.

(We cant use current cython release due to a different issue - cython/cython#3395)

Will ping on here when ready.

@jbrockmendel

@TomAugspurger
Copy link
Contributor

@alimcmaster1 you may need to manually skip the clipboard tests on this build.

@alimcmaster1 alimcmaster1 changed the title WIP: CI: Setup 3.9 Travis Build CI: Setup 3.9 Travis Build May 1, 2020
@alimcmaster1
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Commenter does not have sufficient privileges for PR 33505 in repo pandas-dev/pandas

@alimcmaster1
Copy link
Member Author

Azure pipelines don't seem to be triggering

@alimcmaster1 alimcmaster1 reopened this May 2, 2020
@alimcmaster1
Copy link
Member Author

@pandas-dev/pandas-core 3.9 build is ready. (Azure seems to be playing up - all jobs have ran but doesn’t seem to be reporting back to my PR)

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u add an issue to revert this once conda builds are good

a question about wheels

ci/build39.sh Outdated
pip install cython --pre # https://github.com/cython/cython/issues/3395

# Alternative for getting numpy:
# pip install --pre -f https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com/ numpy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these wheels work yet?

ci/build39.sh Outdated
python setup.py install
cd ..
rm -rf numpy
pip install --pre -f https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com numpy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might not be the right address iirc this changed
maybe have to look on the numpy issue list

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these might be older:

https://anaconda.org/scipy-wheels-nightly/numpy/files
i think is the new location (includes scipy as well)

let’s update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh nice - thanks wasn't aware! Will update the numpy dev build too in a separate PR.

thanks!

@alimcmaster1
Copy link
Member Author

all green & raised an issue for later follow ups @jreback

@jreback jreback mentioned this pull request May 4, 2020
@alimcmaster1
Copy link
Member Author

alimcmaster1 commented May 4, 2020

Resorted to building numpy from source:

Collecting numpy
  Downloading numpy-1.18.3.zip (5.4 MB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
    Preparing wheel metadata: started
    Preparing wheel metadata: finished with status 'done'
Building wheels for collected packages: numpy
  Building wheel for numpy (PEP 517): started
  Building wheel for numpy (PEP 517): still running...
  Building wheel for numpy (PEP 517): still running...
  Building wheel for numpy (PEP 517): finished with status 'done'
  Created wheel for numpy: filename=numpy-1.18.3-cp39-cp39-linux_x86_64.whl size=15218460 sha256=a8ece5537cef5c3f6110576f4937c80bfc60d6a3d4a6c6d27353b2e3dc6f677e
  Stored in directory: /home/travis/.cache/pip/wheels/b0/63/be/cd7680896e3713ce13b5b5748563e78e0cfe5ea9c0c20143a1```

@alimcmaster1
Copy link
Member Author

@jreback @jbrockmendel any comments here? All green

@jreback jreback added this to the 1.1 milestone May 9, 2020
pip install cython --pre # https://github.com/cython/cython/issues/3395

git clone https://github.com/numpy/numpy
cd numpy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the wheel instead?
iirc the existing dev build was already changed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried above - but there are no 3.9 wheels available yet on scipy-wheels-night or the old rackcdn url

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update when available - tracking in #33948

@jreback jreback merged commit 89e44e6 into pandas-dev:master May 9, 2020
@jreback
Copy link
Contributor

jreback commented May 9, 2020

thanks @alimcmaster1

rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
* Python 3.9 build

* Python 3.9 build

* Python 3.9 build

* Python 3.9 build

* Update build39.sh

minor comments

* Update .travis.yml

Skip clipboard tests

* Python 3.9 tests

* Dummy commit

* Use numpy master manylinux wheel

* use scipy nightly wheels

* Build numpy from source
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request May 10, 2020
* Python 3.9 build

* Python 3.9 build

* Python 3.9 build

* Python 3.9 build

* Update build39.sh

minor comments

* Update .travis.yml

Skip clipboard tests

* Python 3.9 tests

* Dummy commit

* Use numpy master manylinux wheel

* use scipy nightly wheels

* Build numpy from source
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request May 13, 2020
* Python 3.9 build

* Python 3.9 build

* Python 3.9 build

* Python 3.9 build

* Update build39.sh

minor comments

* Update .travis.yml

Skip clipboard tests

* Python 3.9 tests

* Dummy commit

* Use numpy master manylinux wheel

* use scipy nightly wheels

* Build numpy from source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants