CLN: assorted cleanups, annotations, de-privatizing #33497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Apr 14, 2020
| @@ -313,7 +313,9 @@ def test_subtraction_ops(self): | |||
| tm.assert_index_equal(result, expected, check_names=False) | |||
|
|
|||
| result = dti - td | |||
| expected = DatetimeIndex(["20121231", "20130101", "20130102"], name="bar") | |||
| expected = DatetimeIndex( | |||
| ["20121231", "20130101", "20130102"], freq="D", name="bar" | |||
There was a problem hiding this comment.
Is this a bugfix with the freq? Worth a whatsnew?
There was a problem hiding this comment.
No. ATM assert_index_equal doesnt check for matching freq. Moving towards adding that check, but ATM it breaks about 500 tests. Honestly not sure why this edit made it into this branch.
jreback
approved these changes
Apr 17, 2020
CloseChoice
pushed a commit
to CloseChoice/pandas
that referenced
this pull request
Apr 20, 2020
* de-privatize * CLN: assorted cleanups, annotations
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
* de-privatize * CLN: assorted cleanups, annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.