Send None parameter to pandas-gbq to set no progress bar

[sumanau7]

• closes BUG: Can't disable progress bar for read_gbq #33360
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[sumanau7]

@TomAugspurger Request for review.

[alimcmaster1]

Do we need to set the min version as mention in #33360 (comment)

[sumanau7]

@alimcmaster1 need help in understanding the reason for build failures, should we just re-run it ?

[alimcmaster1]

@alimcmaster1 need help in understanding the reason for build failures, should we just re-run it ?

Sure - if you merge master this should now be fixed.

[sumanau7]

@jreback Green

[alimcmaster1]

@sumanau7 please see my comments above. We need to change the min supported before doing this https://pandas.pydata.org/pandas-docs/stable/getting_started/install.html#optional-dependencies it’s currently 0.8.0 you are proposing 0.12.0 right?

[sumanau7]

@sumanau7 please see my comments above. We need to change the min supported before doing this https://pandas.pydata.org/pandas-docs/stable/getting_started/install.html#optional-dependencies it’s currently 0.8.0 you are proposing 0.12.0 right?

@alimcmaster1 Have done that change, can you please verify if these are the only places where this change is required

[alimcmaster1]

@alimcmaster1 Have done that change, can you please verify if these are the only places where this change is required

You will also need to update _optional.py

[alimcmaster1]

Note current default behaviour of pandas read_gbq is tdqm progress bar. This change makes the default no progress bar right?. Do we want to be consistent with pandas_gbq and use tdqm by default?

(From @TomAugspurger comment here #33360 (comment) sounds like we should have same default :) )

[alimcmaster1]

This looks pretty much there to me. (Just need to decide on this point)

@sumanau7 looks like some of the tests are failing (logs on longer available) mind taking a look? - https://github.com/pandas-dev/pandas/pull/33477/checks?check_run_id=588645024

[alimcmaster1]

Looks like this build job it failing - (not publishing back to PR) https://github.com/pandas-dev/pandas/pull/33477/checks?check_run_id=588645024

[jreback]

this looks ok. @sumanau7 can you add a whatsnew note that we have fixed this issue, and now recommend pandas-gbq >=0.12.0. please merge master and ping on green.

[alimcmaster1]

@sumanau7 could you update as per Jeff’s comments? Thanks!

[jreback]

thanks @sumanau7