BUG: None converted to NaN after groupby first and last #33462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Apr 10, 2020
| @@ -893,7 +893,7 @@ def group_last(rank_t[:, :] out, | |||
| for j in range(K): | |||
| val = values[i, j] | |||
|
|
|||
| if not checknull(val): | |||
| if not checknull(val) or val is None: | |||
There was a problem hiding this comment.
can you add a comment here of why we are doing this
| @@ -986,7 +986,7 @@ def group_nth(rank_t[:, :] out, | |||
| for j in range(K): | |||
| val = values[i, j] | |||
|
|
|||
| if not checknull(val): | |||
| if not checknull(val) or val is None: | |||
| @@ -94,6 +94,16 @@ def test_nth_with_na_object(index, nulls_fixture): | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("method", ["first", "last"]) | |||
| def test_first_last_with_None(method): | |||
| # https://github.com/pandas-dev/pandas/issues/32800 | |||
There was a problem hiding this comment.
can you add a comment, that we wish to preserve None in object dtypes.
jreback
added
Bug
Dtype Conversions
jreback
approved these changes
Apr 17, 2020
|
thanks! |
Closed
5 tasks
CloseChoice
pushed a commit
to CloseChoice/pandas
that referenced
this pull request
Apr 20, 2020
…3462) * BUG: None converted after groupby first and last * BUG: whatsnew entry
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
May 5, 2020
…NaN after groupby first and last)
simonjayhawkins
added a commit
that referenced
this pull request
May 5, 2020
…groupby first and last) (#33998) Co-authored-by: JDkuba <[email protected]>
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
…3462) * BUG: None converted after groupby first and last * BUG: whatsnew entry
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis PR solves #32800. In #32124
not checknull()was introduced togroupfirst()andgrouplast().Noneis not caught in this conditional and it's being converted tonanbecause of that.I'm a newbie and not sure whether I should add whatsnew entry or not. Should I?