TST: concat(..., copy=False) with datetime tz-aware data raises ValueError: cannot create a DatetimeTZBlock without a tz #33458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it fails on version 0.24.1 but passes on current version
WillAyd
requested changes
Apr 10, 2020
jreback
requested changes
Apr 10, 2020
pandas/tests/dtypes/test_concat.py
Outdated
| # Regression test for issue 25257 | ||
| df = pd.DataFrame({'timestamp': [pd.Timestamp('2020-04-08 09:00:00.709949+0000', | ||
| tz='UTC')], }) | ||
| result = pd.concat([df], copy=False) |
There was a problem hiding this comment.
can you parameterize on copy=[True, False]
There was a problem hiding this comment.
can you push up the change
…mit to test out normally with floor(1) + floor(2)
…xpression before returning res() of the value which was an abstraction of the floor function being passed in
…this commit to test out normally with floor(1) + floor(2)" This reverts commit f095a74.
This reverts commit a0c4e2b.
This reverts commit de1373e.
This reverts commit ce8fa9c.
|
I'm not sure why the Publish benchmarks artifact error is popping up on Travis-CI tests. Any help would be appreciated @jreback |
jreback
changed the title
|
can you merge master |
jreback
requested changes
Jun 14, 2020
pandas/core/computation/expr.py
Outdated
| @@ -670,19 +670,26 @@ def visit_Call(self, node, side=None, **kwargs): | |||
| ) | |||
|
|
|||
| return res(*new_args) | |||
| elif isinstance(res, np.ufunc): | |||
| new_args = [self.visit(arg) for arg in node.args] | |||
| @@ -727,6 +727,10 @@ def test_line_continuation(self): | |||
| result = pd.eval(exp, engine=self.engine, parser=self.parser) | |||
| assert result == 12 | |||
|
|
|||
| def test_floor_expression(self): | |||
pandas/tests/dtypes/test_concat.py
Outdated
| # Regression test for issue 25257 | ||
| df = pd.DataFrame({'timestamp': [pd.Timestamp('2020-04-08 09:00:00.709949+0000', | ||
| tz='UTC')], }) | ||
| result = pd.concat([df], copy=False) |
There was a problem hiding this comment.
can you push up the change
|
@SurajH1 i've pushed a few changes to the branch of this PR. I notice you raised the PR from master. In future you should create a seperate branch, see https://pandas.pydata.org/docs/dev/development/contributing.html#creating-a-branch |
jorisvandenbossche
approved these changes
Jul 13, 2020
|
Thanks @SurajH1 and @simonjayhawkins ! |
fangchenli
pushed a commit
to fangchenli/pandas
that referenced
this pull request
Jul 16, 2020
…Error (pandas-dev#33458) Co-authored-by: Simon Hawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n version 0.24.1 but passes on current version