BUG: weights is not working for multiple columns in df.plot.hist
#33440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Apr 9, 2020
pandas/tests/plotting/test_frame.py
Outdated
| df2 = pd.DataFrame(dict(zip(["A", "B"], 0.1 * np.random.randn(2, 100,)))) | ||
| ax2 = _check_plot_works(df2.plot, kind="hist") | ||
|
|
||
| self._check_data(ax1, ax2) |
There was a problem hiding this comment.
Is there a way in the test to check that the weights are appropriately rendered by column?
There was a problem hiding this comment.
thanks for taking a look! @WillAyd
good point, i slightly changed the test, and i think: in order to check weights to be rendered appropriately, we could use height in rectangle patches because histogram is essentially rectangles. therefore, for instance, weights for all is 0.1 as in original example, the height of plot should be 0.1 times of original one without weights.
what do you think of this approach?
|
thanks @charlesdong1991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff