Skip to content

BUG: Fix bug when concatenating Index of strings #33436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2020
Merged

BUG: Fix bug when concatenating Index of strings #33436

merged 1 commit into from
Apr 10, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Apr 9, 2020

@dsaxton dsaxton added Bug Strings String extension data type and string data labels Apr 9, 2020
WillAyd
WillAyd approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.1 milestone Apr 9, 2020
@jreback jreback merged commit ef9b938 into pandas-dev:master Apr 10, 2020
@jreback
Copy link
Contributor

jreback commented Apr 10, 2020

thanks @dsaxton

@dsaxton dsaxton deleted the cat-index branch April 10, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Bug Strings String extension data type and string data
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

BUG: str.cat produces NaNs when others is an Index
3 participants
@dsaxton @jreback @WillAyd