-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Add numba engine to groupby.aggregate #33388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 21 commits
194bf7f
7d42379
2124b81
2321693
0f8a692
1d09ce1
38e4485
79ee638
b43f183
632fb0c
f30ba2b
a8b7fdd
dadba23
6e4cdd1
7ffe304
9fc1068
599a640
4d1cbd5
7554190
0729230
4092882
42b5171
7a9055c
3004046
123e53a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,25 @@ | |
NUMBA_FUNC_CACHE: Dict[Tuple[Callable, str], Callable] = dict() | ||
|
||
|
||
def is_numba_util_related_error(err_message: str) -> bool: | ||
""" | ||
Check if an error was raised from one of the numba utility functions | ||
|
||
For cases where a try/except block has mistakenly caught the error | ||
and we want to re-raise | ||
|
||
Parameters | ||
---------- | ||
err_message : str, | ||
exception error message | ||
|
||
Returns | ||
------- | ||
bool | ||
""" | ||
return "The first" in err_message or "numba does not" in err_message | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you actually just check the class type here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I raise Should I make a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, let's have a separate exception (but in a followon) |
||
|
||
|
||
def check_kwargs_and_nopython( | ||
kwargs: Optional[Dict] = None, nopython: Optional[bool] = None | ||
) -> None: | ||
|
@@ -76,7 +95,6 @@ def jit_user_function( | |
---------- | ||
func : function | ||
user defined function | ||
|
||
nopython : bool | ||
nopython parameter for numba.JIT | ||
nogil : bool | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you condense these to a single function call (with whatever return args you need later on)
you can certainly leave these functions individually in core.util.numba_, just when you are calling it would make th api simpler here. (also if you can do this simplification other places we call numba).
can do this in a followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure can follow up with this cleanup