BUG: is_categorical shouldnt recognize Dtype objects #33377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Apr 7, 2020
| @@ -68,9 +68,6 @@ | |||
| ensure_float64 = algos.ensure_float64 | |||
| ensure_float32 = algos.ensure_float32 | |||
|
|
|||
| _ensure_datetime64ns = conversion.ensure_datetime64ns | |||
| _ensure_timedelta64ns = conversion.ensure_timedelta64ns | |||
There was a problem hiding this comment.
unrelated edit before i figured out what this branch was about; these are never used
jbrockmendel
commented
Apr 7, 2020
| @@ -4716,7 +4716,7 @@ def groupby(self, values) -> PrettyDict[Hashable, np.ndarray]: | |||
| # TODO: if we are a MultiIndex, we can do better | |||
| # that converting to tuples | |||
| if isinstance(values, ABCMultiIndex): | |||
| values = values.values | |||
| values = values._values | |||
There was a problem hiding this comment.
unrelated edit from before i figured out what this branch was about
|
This will need a deprecation cycle right? |
id classify this as a bugfix, but OK either way |
|
the other option is just to deprecate it, since we only use is_categorical in a few places and its more likely than not to cause confusion |
Merged
|
Closing in favor of #33385. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_categorical(obj) is used in a couple places where we then go on to access
obj.dtype, so this should not returnTrueif we have aCategoricalDtypeobject.