DOC/TYP: Fixed typing and doc #33374
Conversation
pandas/core/aggregation.py
Outdated
| def normalize_keyword_aggregation(kwargs: dict) -> Tuple[dict, List[str], List[int]]: | ||
| def normalize_keyword_aggregation( | ||
| kwargs: dict, | ||
| ) -> Tuple[DefaultDict, Tuple[Hashable, ...], "np.ndarray"]: |
There was a problem hiding this comment.
@MomIsBestFriend can you git bisect or blame to find out what's the story behind the change here.
There was a problem hiding this comment.
@simonjayhawkins It looks like no one can agree on the placement of this function, as it's moved around constantly.
But it looks like parts of the changes are made in #30497 while migrating from orderedict to defaultdict
There was a problem hiding this comment.
normalize_keyword_aggregation is only called by aggregate in core\groupby\generic.py.
the core\groupby\generic.py module is currently excluded by check_untyped_defs and aggregate does not have type hints.
maybe worth typing aggregate as well to ensure consistency.
There was a problem hiding this comment.
@simonjayhawkins Nice! thanks to that tip I could annotate with much more specific type hints.
pandas/core/aggregation.py
Outdated
| @@ -40,7 +43,9 @@ def is_multi_agg_with_relabel(**kwargs) -> bool: | |||
| ) | |||
|
|
|||
|
|
|||
| def normalize_keyword_aggregation(kwargs: dict) -> Tuple[dict, List[str], List[int]]: | |||
| def normalize_keyword_aggregation( | |||
| kwargs: dict, | |||
There was a problem hiding this comment.
this should be Dict from typing. can you see if you can also add type parameters to Dict.
| @@ -909,7 +911,9 @@ class DataFrameGroupBy(GroupBy[DataFrame]): | |||
| axis="", | |||
| ) | |||
| @Appender(_shared_docs["aggregate"]) | |||
| def aggregate(self, func=None, *args, **kwargs): | |||
| def aggregate( | |||
| self, func: Optional[DefaultDict[str, List[Scalar]]] = None, *args, **kwargs | |||
There was a problem hiding this comment.
this can also be a list / dict of callables no?
|
@MomIsBestFriend can you rebase (and address any actionable comments) |
|
Thanks @MomIsBestFriend closing as stale. ping to reopen. |
pandas/core/aggregation.py#33263 (review)black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff