TST: add read_json test #GH32383 #33345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 7, 2020
mroeschke
reviewed
Apr 7, 2020
mroeschke
reviewed
Apr 7, 2020
WillAyd
requested changes
Apr 7, 2020
Co-Authored-By: Simon Hawkins <[email protected]>
WillAyd
requested changes
Apr 9, 2020
jreback
requested changes
Apr 10, 2020
| @@ -237,6 +237,22 @@ def test_build_series(self): | |||
|
|
|||
| assert result == expected | |||
|
|
|||
| def test_read_json_from_to_json_results(self): | |||
There was a problem hiding this comment.
can you add both of the construction methods from the OP.
There was a problem hiding this comment.
sorry, I am confused. Can you elaborate more?
There was a problem hiding this comment.
since the second construction will always work, is it necessary to add a test here?
There was a problem hiding this comment.
how about now?
jreback
approved these changes
Apr 12, 2020
|
thanks @BenjaminLiuPenrose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff