REF: replace column-wise, remove BlockManager.apply filter kwarg #33340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Clean
Internals
jreback
requested changes
Apr 6, 2020
pandas/core/generic.py
Outdated
| # Note: we only get here with self.ndim == 2 | ||
| for i in range(len(ax)): | ||
| if ax[i] in to_replace: | ||
| ser = self._ixs(i, axis=1) |
There was a problem hiding this comment.
i would just use .iloc here
pandas/core/generic.py
Outdated
| for i in range(len(ax)): | ||
| if ax[i] in value: | ||
| v = value[ax[i]] | ||
| ser = self._ixs(i, axis=1) |
There was a problem hiding this comment.
same,
can you factor this to a function instead.
There was a problem hiding this comment.
refactored + green
i think in follow-up might be able to use this new helper method in one or two more places
jreback
reviewed
Apr 8, 2020
| @@ -4025,6 +4025,41 @@ def replace( | |||
| method=method, | |||
| ) | |||
|
|
|||
| def _replace_columnwise( | |||
There was a problem hiding this comment.
i think may make sense to move this somewhere, maybe missing.py just to try to reduce size in this module. anyhow for another day.
|
thanks |
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Apr 8, 2020
jreback
pushed a commit
that referenced
this pull request
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #33279.