Skip to content

PLT: Order of plots does not preserve the column orders in df.hist #33336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 5, 2020

Conversation

charlesdong1991
Copy link
Member

@charlesdong1991 charlesdong1991 changed the title BUG/PLT: Order of columns is sorted alphabetically in df.hist BUG/PLT: Order of plots does not preserve the column orders in df.hist Apr 6, 2020
@charlesdong1991 charlesdong1991 changed the title BUG/PLT: Order of plots does not preserve the column orders in df.hist PLT: Order of plots does not preserve the column orders in df.hist Apr 6, 2020
@charlesdong1991
Copy link
Member Author

could you please take a look? ^^ @WillAyd @jreback

thanks!

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping. Minor nit on whatsnew but otherwise lgtm

I wasn't too familiar with try_sort. Looks like there's only one other use in pandas/core/indexes/api.py so separately might be worth cleaning up if not required

@@ -536,6 +536,7 @@ Plotting
- :func:`.plot` for line/bar now accepts color by dictonary (:issue:`8193`).
- Bug in :meth:`DataFrame.plot.hist` where weights are not working for multiple columns (:issue:`33173`)
- Bug in :meth:`DataFrame.boxplot` and :meth:`DataFrame.plot.boxplot` lost color attributes of ``medianprops``, ``whiskerprops``, ``capprops`` and ``medianprops`` (:issue:`30346`)
- Bug in :meth:`DataFrame.hist` where the column is sorted given the ``column`` is assigned or not. (:issue:`29235`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Bug in :meth:`DataFrame.hist` where the column is sorted given the ``column`` is assigned or not. (:issue:`29235`)
- Bug in :meth:`DataFrame.hist` where the order of the ``column`` argument was ignored (:issue:`29235`)

@WillAyd WillAyd added this to the 1.1 milestone Apr 29, 2020
@charlesdong1991
Copy link
Member Author

charlesdong1991 commented Apr 30, 2020

thanks for your review! @WillAyd I rephrase the whatsnew note

the build failure is unrelated

I will take a look at the other use of try_sort and see if it is needed, if not needed, I will deprecate it @WillAyd

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@charlesdong1991
Copy link
Member Author

ping

seems it is the azure machine issue @WillAyd @jreback

@charlesdong1991
Copy link
Member Author

ping @WillAyd @jreback

@WillAyd WillAyd merged commit 927ff7a into pandas-dev:master May 5, 2020
@WillAyd
Copy link
Member

WillAyd commented May 5, 2020

Great thanks @charlesdong1991

@charlesdong1991 charlesdong1991 deleted the fix_issue_29235 branch May 19, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categories reordered to alphabetical when plotting histograms
2 participants