-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
PLT: Order of plots does not preserve the column orders in df.hist #33336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping. Minor nit on whatsnew but otherwise lgtm
I wasn't too familiar with try_sort
. Looks like there's only one other use in pandas/core/indexes/api.py so separately might be worth cleaning up if not required
doc/source/whatsnew/v1.1.0.rst
Outdated
@@ -536,6 +536,7 @@ Plotting | |||
- :func:`.plot` for line/bar now accepts color by dictonary (:issue:`8193`). | |||
- Bug in :meth:`DataFrame.plot.hist` where weights are not working for multiple columns (:issue:`33173`) | |||
- Bug in :meth:`DataFrame.boxplot` and :meth:`DataFrame.plot.boxplot` lost color attributes of ``medianprops``, ``whiskerprops``, ``capprops`` and ``medianprops`` (:issue:`30346`) | |||
- Bug in :meth:`DataFrame.hist` where the column is sorted given the ``column`` is assigned or not. (:issue:`29235`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Bug in :meth:`DataFrame.hist` where the column is sorted given the ``column`` is assigned or not. (:issue:`29235`) | |
- Bug in :meth:`DataFrame.hist` where the order of the ``column`` argument was ignored (:issue:`29235`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Great thanks @charlesdong1991 |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff