Skip to content

BLD: Increase minimum version of Cython to 0.29.16 #33334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2020
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/deps/azure-36-32bit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ dependencies:
# see comment above
- pip
- pip:
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
2 changes: 1 addition & 1 deletion ci/deps/azure-36-locale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- python=3.6.*

# tools
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- pytest-asyncio
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-36-locale_slow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- python=3.6.*

# tools
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-36-minimum_versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- python=3.6.1

# tools
- cython=0.29.13
- cython=0.29.16
- pytest=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-37-locale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ dependencies:
- python=3.7.*

# tools
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- pytest-asyncio
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-37-numpydev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ dependencies:
- python=3.7.*

# tools
- cython>=0.29.13
- pytest>=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand All @@ -15,6 +14,7 @@ dependencies:
- pytz
- pip
- pip:
- cython>=0.29.16
- "git+git://github.com/dateutil/dateutil.git"
- "-f https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com"
- "--pre"
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-macos-36.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ dependencies:
- python=3.6.*

# tools
- cython>=0.29.13
- pytest>=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand All @@ -32,5 +31,6 @@ dependencies:
- xlwt
- pip
- pip:
- cython>=0.29.16
- pyreadstat
- pyxlsb
2 changes: 1 addition & 1 deletion ci/deps/azure-windows-36.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- python=3.6.*

# tools
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-windows-37.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- python=3.7.*

# tools
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand Down
4 changes: 2 additions & 2 deletions ci/deps/travis-36-cov.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- python=3.6.*

# tools
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand All @@ -15,7 +15,7 @@ dependencies:
# pandas dependencies
- beautifulsoup4
- botocore>=1.11
- cython>=0.29.13
- cython>=0.29.16
- dask
- fastparquet>=0.3.2
- gcsfs
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-36-locale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- python=3.6.*

# tools
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-36-slow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- python=3.6.*

# tools
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-37.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- python=3.7.*

# tools
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-38.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- python=3.8.*

# tools
- cython>=0.29.13
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- hypothesis>=3.58.0
Expand Down
5 changes: 5 additions & 0 deletions doc/source/whatsnew/v1.1.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ Other enhancements

.. ---------------------------------------------------------------------------

Development Changes
^^^^^^^^^^^^^^^^^^^

- The minimum version of Cython is now the most recent bug-fix version (0.29.16).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add this PR number here


.. _whatsnew_110.api.other:

Other API changes
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies:
- asv

# building
- cython>=0.29.13
- cython>=0.29.16

# code checks
- black=19.10b0
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
requires = [
"setuptools",
"wheel",
"Cython>=0.29.13", # Note: sync with setup.py
"Cython>=0.29.16", # Note: sync with setup.py
"numpy==1.13.3; python_version=='3.6' and platform_system!='AIX'",
"numpy==1.14.5; python_version>='3.7' and platform_system!='AIX'",
"numpy==1.16.0; python_version=='3.6' and platform_system=='AIX'",
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ numpy>=1.15
python-dateutil>=2.6.1
pytz
asv
cython>=0.29.13
cython>=0.29.16
black==19.10b0
cpplint
flake8
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def is_platform_mac():


min_numpy_ver = "1.13.3"
min_cython_ver = "0.29.13" # note: sync with pyproject.toml
min_cython_ver = "0.29.16" # note: sync with pyproject.toml

try:
import Cython
Expand Down