Skip to content

CLN: Added static types for pandas/_libs/reduction.pyx #33316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2020
Merged

CLN: Added static types for pandas/_libs/reduction.pyx #33316

merged 3 commits into from
Apr 6, 2020

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Apr 6, 2020
@jreback jreback added this to the 1.1 milestone Apr 6, 2020
@jreback jreback merged commit cac0796 into pandas-dev:master Apr 6, 2020
@ShaharNaveh ShaharNaveh deleted the CLN-StaticTypes-_libs-reduction branch April 6, 2020 15:07
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Apr 6, 2020
@ShaharNaveh @jbrockmendel
CLN: Added static types for pandas/_libs/reduction.pyx (pandas-dev#…
563a64e 
…33316)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel Awaiting requested review from jbrockmendel

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ShaharNaveh @jreback @simonjayhawkins