CLN: assorted cleanups #33297
Merged
CLN: assorted cleanups #33297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Apr 5, 2020
pandas/_libs/tslibs/timedeltas.pyx
Outdated
| @@ -308,7 +313,7 @@ cdef inline int64_t cast_from_unit(object ts, object unit) except? -1: | |||
| int64_t m | |||
| int p | |||
|
|
|||
| m, p = precision_from_unit(unit) | |||
| m, p = precision_from_unit(unit or "ns") | |||
pandas/core/indexes/base.py
Outdated
| @@ -5516,9 +5516,9 @@ def ensure_index(index_like, copy=False): | |||
| # clean_index_list does the equivalent of copying | |||
| # so only need to do this if not list instance | |||
| if copy: | |||
| from copy import copy | |||
| from copy import copy as copy_func | |||
There was a problem hiding this comment.
this should be at the top of the file
jreback
approved these changes
Apr 6, 2020
WillAyd
approved these changes
Apr 7, 2020
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly annotations