Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: Optimize nrows in read_excel #33281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Optimize nrows in read_excel #33281
Changes from 63 commits
900afff
df55b51
8177024
79b34c3
f0a2b8d
70ac234
27cae3a
4248f8c
70f46b3
cdfc05d
502b5e3
4c8a42a
19bb927
6c2a3b5
b865c88
49276da
393a622
e00fff1
b14642b
dfc794a
7b501de
3292f6b
bdd5780
1867088
3c1eb10
88c3117
dc60055
6fdedfd
ba7175c
d884803
368544a
4be3d27
95e3e02
38520e2
0b21e61
c03b46a
aa8cfe9
c9a622d
aa92783
ee16c15
547787a
368b77c
4d69922
b4ae85f
81f8674
7938fcf
7f31a30
ae8b84f
a4f5009
d7a2892
c94b45e
0ab450b
54c7304
ca388dc
9ddc41c
1920905
6d72a34
5ba54a6
2766270
91176ca
f748b78
ac823f5
f4a805d
6f188fe
ba314fe
f923bfd
008add5
c04c494
596806c
2226050
9216210
d9aa319
094d5f7
234dcc6
0afb1b1
33cb733
06003a8
c08709b
c9a2c75
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this interface is obvious at all. prefer simple routines
if should_skip_rows(...):
....
when is a break condition? can you just do it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it. Break condition is now handled differently