Skip to content

DOC: Fixed examples in pandas/core/window #33266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2020

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

>>> df = pd.DataFrame(np.random.randn(10, 3), columns=['A', 'B', 'C'])
>>> df = pd.DataFrame(
... {
... "A": [0.95117561, 0.632442, 0.72290796],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, I personally find these example easier to digest with "simpler numbers" like [1, 2, 3], [4, 5, 6]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh OK, no problem. I'll fix that, was just avoiding random output in the docs.

@mroeschke mroeschke added the Docs label Apr 3, 2020
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ping on green

@WillAyd WillAyd added this to the 1.1 milestone Apr 4, 2020
@WillAyd WillAyd merged commit ab60392 into pandas-dev:master Apr 4, 2020
@WillAyd
Copy link
Member

WillAyd commented Apr 4, 2020

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the DOC-DocTests-core-window branch April 6, 2020 08:34
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants