Skip to content

Display Timedelta nanoseconds #33250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 3, 2020
Merged

Display Timedelta nanoseconds #33250

merged 6 commits into from
Apr 3, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 3, 2020 •
edited
Loading

This allows us to make TimedeltaBlock.to_native_types dispatch to TimedeltaArray._format_native_types. ATM TDBlock.to_native_types has a comment

        # FIXME:
        # should use the formats.format.Timedelta64Formatter here
        # to figure what format to pass to the Timedelta
        # e.g. to not show the decimals say

@WillAyd
Copy link
Member

WillAyd commented Apr 3, 2020

Seems reasonable. I suppose could use a whatsnew

@WillAyd WillAyd added the Timedelta Timedelta data type label Apr 3, 2020
jreback
jreback requested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, lgtm. pls add a whatsnew note. ping on green.

@jreback jreback added this to the 1.1 milestone Apr 3, 2020
@jbrockmendel
Copy link
Member Author

ping

@WillAyd WillAyd merged commit 7b032ec into pandas-dev:master Apr 3, 2020
@WillAyd
Copy link
Member

WillAyd commented Apr 3, 2020

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the bug-tdrepr branch April 3, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Timedelta Timedelta data type
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

BUG: Timedelta repr does not show nanoseconds
3 participants
@jbrockmendel @WillAyd @jreback