DOC: Contributing - escaping backslash. #33243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-escaped backslash disappeared in resulting doc.
WillAyd
reviewed
Apr 2, 2020
Non-escaped backslash disappeared in resulting doc.
Co-Authored-By: William Ayd <[email protected]>
WillAyd
reviewed
Apr 2, 2020
| @@ -295,7 +295,7 @@ Below is a brief overview on how to set-up a virtual environment with Powershell | |||
| under Windows. For details please refer to the | |||
| `official virtualenv user guide <https://virtualenv.pypa.io/en/stable/userguide/#activate-script>`__ | |||
|
|
|||
| Use an ENV_DIR of your choice. We'll use ~\virtualenvs\pandas-dev where | |||
| Use an ENV_DIR of your choice. We'll use ~\<span class="x x-first x-last">\</span>virtualenvs\\pandas-dev where | |||
There was a problem hiding this comment.
What's the point of the span tag here? We typically don't embed HTML like this
There was a problem hiding this comment.
@WillAyd, the putting span tag was not my own action. I simply accepted — I think your — recommendation by clicking a button.
In my cloned Git repository there is a note in this commit:
Co-Authored-By: William Ayd [email protected]
There was a problem hiding this comment.
Suggested change
| Use an ENV_DIR of your choice. We'll use ~\<span class="x x-first x-last">\</span>virtualenvs\\pandas-dev where | |
| Use an ENV_DIR of your choice. We'll use ~\\virtualenvs\\pandas-dev where |
Hmm that's interesting. Maybe GH is just escaping it on its own.
Can try again, but otherwise might want to fix locally and repush. Thanks!
There was a problem hiding this comment.
@WillAyd, your explanation is probably right, thanks. I did as you suggested — fixed it locally and repushed.
Non-escaped backslashes disappeared in resulting doc.
WillAyd
approved these changes
Apr 2, 2020
|
Great thanks @MarianD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-escaped backslash disappeared in resulting doc.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff