TST: Use try/except block to properly catch and handle the exception

[roberthdevries]

Now no more warnings

• closes CI: Exception ignored in: 'pandas._libs.tslibs.util.get_c_string_buf_and_size' #32951
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff

[jbrockmendel]

perf impact?

[roberthdevries]

None, i reran the asv benchmark

[WillAyd]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[WillAyd]

Hmm not sure about this approach though; typically you do want to pass along the error to the caller rather than swallowing

ref https://cython.readthedocs.io/en/latest/src/userguide/language_basics.html#error-return-values does except NULL in the signature not solve the same thing?

[roberthdevries]

This fix should be more to your liking. It handles the exception exactly at the level where it is supposed to be handled.
Rerunning the asv benchmarks tells me that there are no significant changes.

[jreback]

do we have anything in the test suite that hits this now? (if we do can you add this issue number there)

[roberthdevries]

This issue was triggered by the following test: pandas/tests/frame/test_api.py::test_column_name_contains_unicode_surrogate
Which was added because of a fix for #25509

[jreback]

@jbrockmendel

[jbrockmendel]

@WillAyd does this address your concern here? If so, LGTM.

[WillAyd]

Yea this looks good very nicely done. I think good to merge @jreback

[jreback]

thanks @roberthdevries very nice. don't need a whatsnew note here as this is pretty much internal.