Skip to content

DOC: Added check for standard pandas reference #33213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

joybh98
Copy link
Contributor

@joybh98 joybh98 commented Apr 1, 2020

As suggested by @datapythonista , I've added checks in ci/code_checks.sh to look if the pandas is being referenced in a standardized way i.e pandas, not pandas or Pandas

@joybh98 joybh98 changed the title Added check for standard pandas reference DOC: Added check for standard pandas reference Apr 1, 2020
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working. We're here to help, but please try your changes locally before submitting a PR.

@joybh98
Copy link
Contributor Author

joybh98 commented Apr 2, 2020

This is not working. We're here to help, but please try your changes locally before submitting a PR.

@datapythonista my bad, will try my changes locally from now on.

@joybh98
Copy link
Contributor Author

joybh98 commented Apr 2, 2020

This is not working. We're here to help, but please try your changes locally before submitting a PR.

I'm getting ./ci/code_checks.sh: line 243: RET: command not found, I can't understand why I'm getting this error. All the checks are using it.

EDIT : Fixed the error mentioned above, pushing the changes

@datapythonista
Copy link
Member

Once again, can you check locally if things are working? This is my 10th time reviewing this PR and it's obvious once more that this is not working. There are more than 100 cases of the work Pandas in doc/, and your changes are not detecting those. No need for your PRs to be perfect, but can you please stop proposing changes that you didn't try locally even once to see if they run without errors or they make sense? Thank you

@simonjayhawkins
Copy link
Member

@joybhallaa are you still working on this?

@willie3838
Copy link
Contributor

take

@alimcmaster1
Copy link
Member

Closing this looks like @willie3838 is looking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants