-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Added check for standard pandas reference #33213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not working. We're here to help, but please try your changes locally before submitting a PR.
@datapythonista my bad, will try my changes locally from now on. |
I'm getting EDIT : Fixed the error mentioned above, pushing the changes |
Once again, can you check locally if things are working? This is my 10th time reviewing this PR and it's obvious once more that this is not working. There are more than 100 cases of the work |
@joybhallaa are you still working on this? |
take |
Closing this looks like @willie3838 is looking |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
As suggested by @datapythonista , I've added checks in
ci/code_checks.sh
to look if the pandas is being referenced in a standardized way i.e pandas, not pandas or Pandas