-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Make doc decorator a class and replace Appender by doc #33160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6e4b036
use doc replace Appender
HH-MWB 21fa045
upgrade doc decorator from function to class
HH-MWB 363f1be
convert doc decorator back to function
HH-MWB 5b5508d
update name and type from function to callable
HH-MWB eb7d12a
correct type for decorator
HH-MWB 1caee82
update param names be more descriptive
HH-MWB 4c9dc28
Merge branch 'master' of https://github.com/pandas-dev/pandas into do…
HH-MWB 4ebd97b
Merge branch 'master' of https://github.com/pandas-dev/pandas into do…
HH-MWB d3dbe5d
update stacklevel for doc decorator
HH-MWB b4bf49b
update stacklevel for doc decorator
HH-MWB faaf564
update arg names in doc decorator
HH-MWB cc2be1a
solve conflicts
HH-MWB 08a0744
remove ignore to fix mypy error
HH-MWB 11de122
fix mypy error
HH-MWB 34829bb
Merge remote-tracking branch 'upstream/master' into doc-decorator
HH-MWB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
F
(FuncType
) also represent classes, or just functions?func
is now a function or a class (probably worth changing the name).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I agree here. It has been replaced to callable.