STY: Using __all__; removed "noqa" comment

[ShaharNaveh]

• closes #xxxx
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[WillAyd]

lgtm

[jorisvandenbossche]

I am personally -1 on this, I find the relative imports much clearer to signal it are all imports internally from the module.

[ShaharNaveh]

I personally don't have a strong opinion on relative vs absolute imports, just wanted to remove the # flake8: noqa comment.

---

If we do want relative imports in some places, https://dev.pandas.io/docs/development/code_style.html#imports-aim-for-absolute should be updated.

[jbrockmendel]

I find the relative imports much clearer to signal it are all imports internally from the module.

I'm with Joris on this one.

[WillAyd]

absolute imports are recommended by PEP8 and are used 99% of the time in our code base, so I think we should go with this

[jorisvandenbossche]

PEP8 also says:

However, explicit relative imports are an acceptable alternative to absolute imports, especially when dealing with complex package layouts where using absolute imports would be unnecessarily verbose

(which I would say applies here)

So I don't think PEP8 is a good reason to do this.
Consistency within pandas of course is. And it is correct than almost all code uses absolute imports. But that is also because there are regularly PRs like this one that converts to absolute imports that we merge ;) (just meaning, this is a "rule" we set ourselves that can be discussed)

[jreback]

I am personally -1 on this, I find the relative imports much clearer to signal it are all imports internally from the module.

I disagree, we barely use them. having a mix is SO confusing. Since we use absolute almost everywhere we should just continue to do this.

[jreback]

all that said, we could have a policy to use relative in some parts of the codebase. I just don't want to mix it within a file. This file looks fine as is. But we need to define how we communicate this policy (and how its enforced).

[WillAyd]

Is there a path forward here? I'm still OK with this

[jbrockmendel]

I personally don't have a strong opinion on relative vs absolute imports, just wanted to remove the # flake8: noqa comment.

Let's just do the __all__ for now

[WillAyd]

Thanks @MomIsBestFriend