CLN: unused import _libs/reduction + remove "noqa" comment in _libs/__init__.py #33142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2020 17:46
ShaharNaveh
changed the title
WillAyd
reviewed
Mar 30, 2020
| @@ -1,6 +1,15 @@ | |||
| # flake8: noqa | |||
| __all__ = [ | |||
There was a problem hiding this comment.
Is this required? I think unnecessary since we don't hide or disallow importing anything that appears here globally
There was a problem hiding this comment.
The __all__ is required in order to remove the # flake8: noqa comment, otherwise flake8 complains about unused imports.
There was a problem hiding this comment.
But not a deal breaker for me, I only made this change because opening a PR just for the LooseVersion seemed too small.
There was a problem hiding this comment.
Ah forgot about the flake8 warning; I think this is OK as well
WillAyd
approved these changes
Mar 30, 2020
|
Thanks @MomIsBestFriend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff