BUG: create new MI from MultiIndex._get_level_values #33134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
bug_MultiIndex_with_periods
branch
from
3fe0afa to
39cc530
Compare
ShaharNaveh
reviewed
Mar 29, 2020
| idx2 = MultiIndex.from_arrays( | ||
| [idx._get_level_values(level) for level in range(idx.nlevels)] | ||
| ) | ||
| assert all(x.is_monotonic for x in idx2.levels) is True |
There was a problem hiding this comment.
Question, not a blocker.
Is the is True necessary?
There was a problem hiding this comment.
Yeah, in this case it's not needed. I'm in the habit of testing properties with a strict is test, where possible. I'll remove it, but will wait to see if other comments need addressing.
jreback
approved these changes
Mar 30, 2020
|
If PeriodEngine.get_indexer is ever called it will raise AttributeError, ditto get_pad_indexer, get_backfill indexer. |
|
@jreback , this is a regression since v1.0, causes by #32669, so a whatsnew isn't needed here. @jbrockmendel , it looks like it also did that in v1.0?: >>> idx = pd.MultiIndex.from_arrays([pd.PeriodIndex([pd.Period("2019Q1"), pd.Period("2019Q2")], name='b')])
>>> idx2 = pd.MultiIndex.from_arrays([idx._get_level_values(level) for level in range(idx.nlevels)])
>>> idx2.levels[0]._engine.get_indexer(idx.levels[0])
AttributeError: 'super' object has no attribute '_ensure_mapping_populated' # both 1.0 and master |
|
thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffCloses #33131, a weakref was released too early.