BUG: to_datetime with infer_datetime_format dropped timezone names #33133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1862,6 +1862,12 @@ def test_to_datetime_infer_datetime_format_series_start_with_nans(self, cache): | |||
| pd.to_datetime(s, infer_datetime_format=True, cache=cache), | |||
| ) | |||
|
|
|||
| def test_infer_datetime_format_tz_name(self): | |||
| s = pd.Series(["2019-02-02 08:07:13 UTC"]) | |||
There was a problem hiding this comment.
is it just UTC that gets recognized? "GMT"? "UTC-3"?
There was a problem hiding this comment.
Recognizes UTC-3 but not GMT. I'll update with a parameterized test.
jreback
approved these changes
Mar 30, 2020
| @pytest.mark.parametrize( | ||
| "tz_name, offset", [("UTC", 0), ("UTC-3", 180), ("UTC+3", -180)] | ||
| ) | ||
| def test_infer_datetime_format_tz_name(self, tz_name, offset): |
|
LGTM pending GH ref |
|
thanks @mroeschke |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff