REF: remove placement kwarg from Block.concat_same_type #33123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/internals/blocks.py
Outdated
| values = self._concatenator( | ||
| [blk.values for blk in to_concat], axis=self.ndim - 1 | ||
| ) | ||
| values = self._holder._concat_same_type([blk.values for blk in to_concat]) |
There was a problem hiding this comment.
I know the _concatenator -> _holder._concat_same_type change is right now equivalent. But I would maybe leave it as is for now, because actually Categorical._concat_same_type is not implementing the spec of returning its own type / this problem is something we need to fix in general for ExtensionArrays.
There was a problem hiding this comment.
Either way I guess. I'm hopeful Block.concat_same_type will be gone by then
jorisvandenbossche
approved these changes
Mar 30, 2020
jreback
reviewed
Mar 30, 2020
| return self.make_block_same_class( | ||
| values, placement=placement or slice(0, len(values), 1) | ||
| ) | ||
| placement = self.mgr_locs if self.ndim == 2 else slice(len(values)) |
There was a problem hiding this comment.
you can remove the placement arg from make_block_same_class I think (e.g. do this check internally), but for a followon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the path to getting concat logic out of internals