Skip to content

REF: push concat logic out of internals and into concat_compat #33110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2020
Merged

REF: push concat logic out of internals and into concat_compat #33110

merged 3 commits into from
Mar 29, 2020

Conversation

jbrockmendel
Copy link
Member

This changes some empty-array behavior for concat_compat to match the behavior of pd.concat(list_of_series), see new test.

The follow-up to this basically gets concat out of internals altogether.

@jreback jreback added Refactor Internal refactoring of code Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Mar 29, 2020
@jreback jreback added this to the 1.1 milestone Mar 29, 2020
@jreback jreback merged commit 6a0acd9 into pandas-dev:master Mar 29, 2020
@jreback
Copy link
Contributor

jreback commented Mar 29, 2020

thanks

@jreback jreback mentioned this pull request Mar 29, 2020
Merged
5 tasks
@jbrockmendel jbrockmendel deleted the concat_same_type branch March 29, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor Internal refactoring of code Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback